Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move events group name to component params. #61

Closed
olegbaturin opened this issue Sep 13, 2023 · 2 comments
Closed

Move events group name to component params. #61

olegbaturin opened this issue Sep 13, 2023 · 2 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@olegbaturin
Copy link
Contributor

Move config group name for events to component params.

'yiisoft/event' => [
    'eventsGroup' => 'events-web',
],

ListenerCollection::class => static fn (Factory $factory) => $factory->create($params['yiisoft/event']['eventsGroup']),

Additional info

ListenerCollection::class => static fn (Factory $factory) => $factory->create($config->get('events-web')),

@vjik
Copy link
Member

vjik commented Sep 13, 2023

Also need do same with config group name from di-console.php.
Need to don't forget add docs to readme about this feature.

@vjik
Copy link
Member

vjik commented Sep 17, 2023

Done by #62

@vjik vjik closed this as completed Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

No branches or pull requests

2 participants