Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move events group name to component params (#61) #62

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Move events group name to component params (#61) #62

merged 3 commits into from
Sep 17, 2023

Conversation

olegbaturin
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #61

@olegbaturin
Copy link
Contributor Author

For the first consideration

@what-the-diff
Copy link

what-the-diff bot commented Sep 15, 2023

PR Summary

  • Enhancement Addition in Changelog
    The 'CHANGELOG.md' file has been updated to reflect a recent improvement (Move events group name to component params. #61) made by @olegbaturin.

  • New Parameters in Composer File
    In the composer.json file, we introduced two new parameters: params-web and params-console, which will improve our configuration management.

  • Configuration File Updates
    The files di-console.php and di-web.php in the config directory were modified. This change allows the ListenerCollection to get the eventsGroup parameter from $params['yiisoft/yii-event'], making our event handling more efficient.

  • Application of New Configuration Files
    We've added params-console.php and params-web.php to the config directory. These will help in providing separate configurations for web and console.

  • Updates in Testing Configurations
    Changes have been made to createContainer() and createConfig() methods in the ConfigTest.php file in the tests directory. This change allows the di parameter to include $postfix if it is not null, and the params parameter to include params- followed by $postfix if it is also not null, leading to a more flexible testing setup.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d3f8300) 100.00% compared to head (6d8a4e2) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #62   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        47        47           
===========================================
  Files              5         5           
  Lines            120       120           
===========================================
  Hits             120       120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/params-console.php Outdated Show resolved Hide resolved
config/params-web.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@olegbaturin
Copy link
Contributor Author

What's wrong with rector?

@olegbaturin olegbaturin requested a review from vjik September 17, 2023 08:21
@vjik
Copy link
Member

vjik commented Sep 17, 2023

What's wrong with rector?

Rector workflow don't work in PR from forks. So far we have not able to solve this problem. May be has idea how fix it?

@vjik vjik merged commit 56278ce into yiisoft:master Sep 17, 2023
16 of 17 checks passed
@vjik
Copy link
Member

vjik commented Sep 17, 2023

Thanks 👍

@olegbaturin
Copy link
Contributor Author

What's wrong with rector?

Rector workflow don't work in PR from forks. So far we have not able to solve this problem. May be has idea how fix it?

maybe helps
actions/checkout#455

@olegbaturin olegbaturin deleted the #61-move-events-group-name-to-params branch September 17, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants