Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring of CallableFactory and ListenerCollectionFactory + Improve psalm #65

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 4, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c456517) 100.00% compared to head (f38b636) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #65   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        47        47           
===========================================
  Files              5         5           
  Lines            120       120           
===========================================
  Hits             120       120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Feb 4, 2024

PR Summary

  • PHP Version Updated in Workflow
    The PHP version in the workflow configuration file has been updated to include version 8.3. This will allow our tests and operations to run on this newer version.

  • Minor Refactoring in Code Modules
    Some minor code updates have been made to improve efficiency in CallableFactory and ListenerCollectionFactory modules. This includes removal of unused annotations and adjusting the return type descriptions.

  • Updates to Project Dependencies
    The version of the code analysis tool (vimeo/psalm) utilized in our project has been updated from version 5.6 to 5.21. This implies more efficient and updated analysis of our codebase.

  • Exclusions & Error Level Settings in Code Analysis Configuration
    Configuration settings have been updated in our code analysis tool. This includes adding a section to exclude the vendor directory from being analyzed, and setting suppression for the MixedAssignment error level. This will prevent unnecessary analysis of certain sections and manage the type of errors highlighted.

  • Changelog Updated with Refactoring Details
    The changelog document was updated with all the refactoring details made on CallableFactory and ListenerCollectionFactory modules. This provides an easy-to-follow history of changes made in the project.

@vjik vjik added the status:code review The pull request needs review. label Feb 4, 2024
@vjik vjik requested a review from a team February 4, 2024 09:26
@vjik vjik merged commit 669f2a2 into master Feb 4, 2024
36 checks passed
@vjik vjik deleted the improve branch February 4, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants