Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm #97

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix psalm #97

merged 2 commits into from
Feb 8, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 8, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 8, 2024

PR Summary

  • Update of Actions Workflow File
    Changes were made in the .github/workflows/static.yml file. These changes now allow for the handling of push events for the master branch and allow the use of updated php versions 8.1, 8.2, and 8.3.

  • New job addition to Workflow
    A new job titled psalm80 was incorporated into the .github/workflows/static.yml file. This new job makes use of a separate psalm configuration file named psalm80.yml and is designed to work with PHP version 8.0.

  • Package Update in Composer File
    An enhancement was made to the composer.json file; the package vimeo/psalm has been updated and now supports version "^4.30|^5.21".

  • Introduction of New Config File
    A fresh config file named psalm80.xml has been added, offering a separate psalm configuration.

  • Improvement of Psalm Configuration
    In the existing psalm.xml file, two more issue handlers have been implemented. These issue handlers, MixedAssignment and RiskyTruthyFalsyComparison, suppress certain error levels.

  • Code Refactoring in src/ViewRenderer.php File
    Some cleaning up has been done in the src/ViewRenderer.php file. An unused variable in the injectLinkTags method has been removed, making the code more efficient.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f14de7e) 100.00% compared to head (6ee852f) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #97   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        75        75           
===========================================
  Files              6         6           
  Lines            237       237           
===========================================
  Hits             237       237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 94bdd94 into master Feb 8, 2024
23 of 24 checks passed
@vjik vjik deleted the fix-psalm branch February 8, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant