Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Callback middleware unit tests #113

Merged
merged 5 commits into from
Sep 10, 2019
Merged

Callback middleware unit tests #113

merged 5 commits into from
Sep 10, 2019

Conversation

romkatsu
Copy link
Member

@romkatsu romkatsu commented Sep 8, 2019

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues #105

@samdark samdark added status:code review The pull request needs review. type:test Test labels Sep 8, 2019
samdark
samdark suggested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. Some important cases are missing:

  • Check that request is passed to callback.
  • Check that when using type-hints in a callback, DI container get() is called i.e. autowiring works.

@samdark samdark added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Sep 9, 2019
@romkatsu romkatsu requested a review from samdark September 9, 2019 21:05
@samdark samdark merged commit 7a685f9 into yiisoft:master Sep 10, 2019
@samdark
Copy link
Member

samdark commented Sep 10, 2019

Merged. Thank you!

devanych pushed a commit that referenced this pull request Feb 1, 2021
@romkatsu @devanych
Add tests for Callback middleware (#113)
55cb2b2
devanych pushed a commit that referenced this pull request Feb 1, 2021
@romkatsu @devanych
Add tests for Callback middleware (#113)
79eb56a
devanych pushed a commit that referenced this pull request Feb 1, 2021
@romkatsu @devanych
Add tests for Callback middleware (#113)
61c321b
devanych pushed a commit that referenced this pull request Feb 1, 2021
@romkatsu @devanych
Add tests for Callback middleware (#113)
9805931
devanych pushed a commit that referenced this pull request Feb 1, 2021
@romkatsu @devanych
Add tests for Callback middleware (#113)
74091f0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdark samdark Awaiting requested review from samdark

Assignees
No one assigned
Labels
status:under development Someone is working on a pull request. type:test Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romkatsu @samdark