This repository was archived by the owner on Jun 29, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems right, because it doesn't return $this, it's a clone of $this : https://github.com/Nyholm/psr7/blob/master/src/ServerRequest.php#L143-L149 |
demonking
reviewed
Nov 1, 2019
demonking
reviewed
Nov 1, 2019
It is part of PSR: https://github.com/php-fig/http-message/blob/efd67d1dc14a7ef4fc4e518e7dee91c271d524e4/src/ServerRequestInterface.php#L235-L237 |
samdark
approved these changes
Nov 2, 2019
Merged. Thank you! |
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
devanych
pushed a commit
that referenced
this pull request
Feb 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made one change in
AuthMiddleware
. I think that without the change these lines is uselessyii-web/src/Auth/AuthMiddleware.php
Lines 13 to 15 in a88d7fd
yii-web/src/Auth/AuthMiddleware.php
Line 29 in a88d7fd
yii-web/src/Auth/AuthMiddleware.php
Lines 42 to 45 in a88d7fd