Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #223: Do not start session for Alert widget in case no session ID… #224

Closed
wants to merge 1 commit into from
Closed

Fix #223: Do not start session for Alert widget in case no session ID… #224

wants to merge 1 commit into from

Conversation

samdark
Copy link
Member

@samdark samdark commented Jul 7, 2020

… was passed

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #223

@samdark samdark added this to the 2.0.37 milestone Jul 7, 2020
@samdark samdark requested a review from a team July 7, 2020 22:20
@samdark samdark added the status:code review The pull request needs review. label Jul 7, 2020
@xepozz
Copy link
Member

xepozz commented Jul 8, 2020

It may break BC.
I think it can be configured via widget options with default value "autostart session enabled"

viktorprogger
viktorprogger approved these changes Jul 31, 2020
View reviewed changes
Copy link

@viktorprogger viktorprogger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what's with Travis. Will you try to restart failed jobs?

@viktorprogger
Copy link

Can't we implement this inside getAllFlashes?

@samdark
Copy link
Member Author

samdark commented Aug 3, 2020

@viktorprogger yeah, maybe.

@viktorprogger
Copy link

@samdark after some reflections I've decided it can lead to some BC because there will no longer be an initiated session where it was before. But I'm also not sure if it matters.

@samdark
Copy link
Member Author

samdark commented Aug 4, 2020

Yes. It is tricky...

@samdark samdark removed this from the 2.0.37 milestone Aug 7, 2020
@samdark samdark closed this Sep 6, 2020
@samdark samdark deleted the 223-do-not-start-session-for-alert branch September 6, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorprogger viktorprogger viktorprogger approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samdark @xepozz @viktorprogger