Fix #13920: Fixed erroneous validation for specific cases

[tim-fischer-maschinensucher]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	#13920

[what-the-diff]

PR Summary

• Correction of validation process for specific scenarios
  The PR includes fixes to the validation process, enhancing it to handle a wider range of cases and prevent any mistakes more effectively.

• Optimization of the GridView label generation
  Previously, there were instances where GridView unnecessarily called the Model::generateAttributeLabel() function to produce label values that aren't required. This PR fixes this to improve overall efficiency.

• Issue with caching a MSSQL query containing BLOB data type resolved
  This update fixes a problem that caused issues with caching a SQL query that holds BLOB data types, therefore optimizing our database interactions.

• Disallowing the export of empty messages in yii\log\FileTarget
  This PR prevents yii\log\FileTarget from exporting empty messages, eliminating unnecessary resource consumption and potential confusion.

• Updates to yii.activeForm.js for better AJAX requests handling
  The code has been enhanced to handle aborting current AJAX requests when a new one is made, enhancing the responsiveness and overall user experience.

• Introduction of currentAjaxRequest variable
  A new variable currentAjaxRequest has been introduced to keep track of the active AJAX request object, providing more granular control over ongoing AJAX requests.

• Fixing the setting of aria-invalid attribute for inputs with errors
  The PR addresses issues with setting the aria-invalid attribute for input fields containing errors, thereby improving form interaction and overall accessibility.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fe73d9c) 48.51% compared to head (cba3a5e) 48.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #19909      +/-   ##
==========================================
+ Coverage   48.51%   48.96%   +0.45%     
==========================================
  Files         445      445              
  Lines       42358    42840     +482     
==========================================
+ Hits        20548    20978     +430     
- Misses      21810    21862      +52     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samdark]

@s1lver do you still remember this case? If so, would you please take a look?

[s1lver]

@s1lver do you still remember this case? If so, would you please take a look?

hmm, 2017... yes, I looked at the related issue but I don't remember how I fixed it back then. I can just check again.

[s1lver]

If confirm is used on the button and the option 'enableAjaxValidation' => true is enabled, then the form is not validated.

<?= Html::submitButton(
     'Submit',
     [
          'class' => 'btn btn-success',
          'data' => [
               'confirm' => 'Confirm message',
          ],
    ]
) ?>

I'm not sure if it can be accepted in this form. Would be nice to add tests

[samdark]

@tim-fischer-maschinensucher do you have time to add a test case to ensure it's not broken again ever?

[tim-fischer-maschinensucher]

I should be able to get to it this or next week.

[tim-fischer-maschinensucher]

I could not reproduce your issue @s1lver. I used the basic project and changed the contact form to fit your description, but everything seemed to work just fine.

[terabytesoftw]

Hi, if we can't reproduce it, and everything seems to work fine, can we close it, and if the problem reappears do we open it again?

[s1lver]

Hmm... I guess something else could have affected me. It's enough for me that there is a test for the old problem

[tim-fischer-maschinensucher]

Is there anything I still need to do for this pr to progress?

[bizley]

Please resolve the conflict and I'll merge it.