Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check compatibility PHP 8.3 #19953

Closed
wants to merge 15 commits into from
Closed

Check compatibility PHP 8.3 #19953

wants to merge 15 commits into from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

Check compatibility with PHP 8.3.

arollmann and others added 11 commits August 21, 2023 15:55
@arollmann
Fix #19924: Fix yii\i18n\Formatter to not throw error `Unknown name…
4c0a00f 
…d parameter` under PHP 8
@particleflux
Add note to UPGRADE guide for change in Validator behavior (#19938)
d5b3b6c 
The `unique` and `exists` validators behave slightly different since
2.0.46 (issue #19407) when used on multiple/combined attributes.

See: #19407 (comment)
@PowerGamer1
Fix #19911: Resolved inconsistency in `ActiveRecord::getAttributeLabe…
8532622 
…l()` with regard of overriding in primary model labels for attributes of related model in favor of allowing such overriding for all levels of relation nesting
@Yur-ok
Fix type (#19939)
4ffb58e
release version 2.0.49
0f7248c
prepare for next release
a2ee220
@terabytesoftw
File Log writer without newline. (#19941)
671fbef 
* File Log writer without newline.

* Fix minor correction.

* Fix tests.

* Add more test.

* Add line to CHANGELOG.md.
@schmunk42 @samdark
added PHP version check, fixed #19925 (#19936)
e8c4a7e 
* added PHP version check, fixed #19925

* added CHANGELOG line

* fixed typo

* fixed typo

---------

Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Bizley <[email protected]>
@schmunk42
removed MIME file tests (#19951)
30b491d 
* removed MIME file tests
see also 0f7248c#commitcomment-127223170

* added CHANGELOG line
@terabytesoftw
Test PHP 8.3.
491eabd
@terabytesoftw
Fix error typo namespace.
3798a0f
@terabytesoftw terabytesoftw marked this pull request as draft September 13, 2023 12:51
@what-the-diff
Copy link

what-the-diff bot commented Sep 13, 2023

PR Summary

  • Introduced PHP version 8.3 in multiple workflows
    The PHP version 8.3 has been incorporated into several workflows, including the build workflow, CI MSSQL, CI MySQL, CI Oracle, CI PostgreSQL, and CI SQLite. This addition ensures that our project stays up-to-date with the latest technology, potentially enhancing performance and offering more code solutions.

  • Updated namespace naming in VarbinaryTest.php
    Adjusted the namespace from 'yiiunit\framework\db\mssql\Type' to 'yiiunit\framework\db\mssql\type' in our VarbinaryTest.php file. This change aligns with our naming convention, ensuring consistency and clarity across our codebase.

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (37714b7) 67.09% compared to head (745961c) 67.14%.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.2   #19953      +/-   ##
============================================
+ Coverage     67.09%   67.14%   +0.04%     
+ Complexity    11229    11228       -1     
============================================
  Files           424      424              
  Lines         35655    35657       +2     
============================================
+ Hits          23924    23942      +18     
+ Misses        11731    11715      -16
Files Changed Coverage Δ
framework/db/Migration.php 21.01% <ø> (ø)
framework/BaseYii.php 81.10% <100.00%> (ø)
framework/db/BaseActiveRecord.php 77.25% <100.00%> (+3.23%) ⬆️
framework/helpers/mimeExtensions.php 100.00% <100.00%> (ø)
framework/helpers/mimeTypes.php 99.89% <100.00%> (-0.11%) ⬇️
framework/i18n/Formatter.php 95.68% <100.00%> (ø)
framework/log/FileTarget.php 85.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw
Copy link
Member Author

I think Yii2 will not have a major compatibility problem with PHP 8.3, we just have to wait for a stable version of ezyang/htmlpurifier and we will be ready.

@terabytesoftw terabytesoftw changed the title Test PHP 8.3 Check compatibility PHP 8.3 Sep 13, 2023
@terabytesoftw terabytesoftw marked this pull request as ready for review September 13, 2023 13:53
@rob006
Copy link
Contributor

rob006 commented Sep 13, 2023

Why is this PR targeting 2.2 branch instead of master?

@terabytesoftw
Copy link
Member Author

terabytesoftw commented Sep 13, 2023 •
edited
Loading

Why is this PR targeting 2.2 branch instead of master?

Hi, because first I wanted to test it in this branch to detect if anything needed to be fixed, so in a while later, i will make the PR to the master, and I will fix what is necessary.

@rob006
Copy link
Contributor

rob006 commented Sep 14, 2023

That sounds like just more work - master needs to be merged to 2.2 anyway, so by applying these changes to master you need to do this only once, and changes will be applied to 2.2 automatically while merging master to 2.2.

I looks like you already used master as a base branch for this PR, so switching target branch should be easy and make this PR more readable (right now it contains a lot of unrelated changes).

@terabytesoftw
Copy link
Member Author

closed in favor #19955.

@terabytesoftw terabytesoftw mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@terabytesoftw @rob006 @Ryadnov @schmunk42 @bizley @arollmann @particleflux @PowerGamer1 @Yur-ok