Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods to Connection::class. #19964

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Remove deprecated methods to Connection::class. #19964

merged 1 commit into from
Sep 22, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Removal of $commandClass property from Connection class
    This update removes an outdated feature in the 'Connection' class. Previously, this feature was responsible for creating new commands for the database. However, this task is now managed more efficiently by another part of the code ($commandMap property) and has improved our system's overall performance. It is an important step towards simplifying our code and minimizing deprecated features.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e7be9e9) 67.14% compared to head (28f160b) 67.14%.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.2   #19964   +/-   ##
=========================================
  Coverage     67.14%   67.14%           
+ Complexity    11226    11225    -1     
=========================================
  Files           424      424           
  Lines         35650    35648    -2     
=========================================
- Hits          23937    23936    -1     
+ Misses        11713    11712    -1     
Files Changed Coverage Δ
framework/db/Connection.php 86.64% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit ce8c654 into yiisoft:2.2 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants