Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods to QueryBuilder::class. #19967

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Remove deprecated methods to QueryBuilder::class. #19967

merged 1 commit into from
Sep 22, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Removal of $conditionBuilders property
    This PR eliminates the $conditionBuilders property from QueryBuilder in framework/db/QueryBuilder.php. This simplification helps us get rid of unnecessary components and makes our code cleaner.

  • Removal of Deprecated Methods
    Various outdated methods that were previously part of the QueryBuilder class in framework/db/QueryBuilder.php have now been removed. This cleanup effort allows the system to be more efficient by eliminating obsolete code components.

  • Elimination of isOldMssql() Method
    The isOldMssql() method from the QueryBuilder class in framework/db/mssql/QueryBuilder.php has been removed. We no longer need it, freeing us from maintaining unused or unnecessary sections of code. This results in a cleaner and more maintainable codebase.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (6b91860) 67.14% compared to head (751bea0) 67.19%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.2   #19967      +/-   ##
============================================
+ Coverage     67.14%   67.19%   +0.04%     
+ Complexity    11225    11216       -9     
============================================
  Files           424      424              
  Lines         35648    35623      -25     
============================================
  Hits          23936    23936              
+ Misses        11712    11687      -25     
Files Changed Coverage Δ
framework/db/QueryBuilder.php 92.78% <ø> (+4.08%) ⬆️
framework/db/mssql/QueryBuilder.php 83.26% <ø> (+0.67%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit 62be1e6 into yiisoft:2.2 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants