Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods to ColumnSchema::class. #19968

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Remove deprecated methods to ColumnSchema::class. #19968

merged 2 commits into from
Sep 22, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Removal of certain column properties
    The specific properties related to JSON and array support in PostgreSQL and MySQL database schemas were removed. This points to a shift towards handling these data types more uniformly in the future.

  • Updates to database typecasting method
    The method responsible for converting data between program and database types was adjusted. Previously, this method was dependent on the now-removed properties. The change hints at a more streamlined, less conditional transformation process.

  • Modification of database testing methods
    The test method for arrays in PostgreSQL was adjusted. This is likely an alignment with the above changes. Rather than expecting a specific class instance, the test is likely to accept more generic results.

  • Change in method for accessing test values
    In database schema tests, the way test values are accessed has been altered. This is in line with the recurrent theme to simplify type handling across various tests and application methods.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (6b91860) 67.14% compared to head (4c86705) 67.13%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.2   #19968      +/-   ##
============================================
- Coverage     67.14%   67.13%   -0.01%     
+ Complexity    11225    11218       -7     
============================================
  Files           424      424              
  Lines         35648    35642       -6     
============================================
- Hits          23936    23930       -6     
  Misses        11712    11712              
Files Changed Coverage Δ
framework/db/mysql/ColumnSchema.php 100.00% <100.00%> (ø)
framework/db/pgsql/ColumnSchema.php 90.69% <100.00%> (+2.94%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit 57d5796 into yiisoft:2.2 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants