Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods to DbMessageSource::class. #19969

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Remove deprecated methods to DbMessageSource::class. #19969

merged 1 commit into from
Sep 22, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Removal of Deprecated Constant
    We've removed a previously used, but now outdated, constant CACHE_KEY_PREFIX from the DbMessageSource.php file. This helps maintain clean and efficient code, which is important for overall system performance and reducing future maintenance efforts.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -42.80% ⚠️

Comparison is base (6b91860) 67.14% compared to head (9cacd4b) 24.34%.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.2   #19969       +/-   ##
=============================================
- Coverage     67.14%   24.34%   -42.80%     
  Complexity    11225    11225               
=============================================
  Files           424      424               
  Lines         35648    35647        -1     
=============================================
- Hits          23936     8680    -15256     
- Misses        11712    26967    +15255     
Files Changed Coverage Δ
framework/i18n/DbMessageSource.php 72.72% <ø> (ø)

... and 225 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit 6618aa8 into yiisoft:2.2 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants