-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Array cache using Yii3 cache library #19980
Conversation
mtangoo
commented
Sep 25, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | 19979 |
PR Summary
These modifications make data operations faster and improve overall application performance. |
What are the benefits of using this package? |
For this array one not really anything significant. But given the plan is to move whole Yii2 caching to use Yii3 packages under the hood, that gives big advantages in terms of quality and easy to maintain. |
Cache in Yii2 is quite mature and does not need that much of the maintenance. This approach also does not really help people to prepare their apps/libraries for Yii 3, which AFAIK was the main goal of Yii 2.2. |
I picked the list from #19875 Another question [That I believe is valid to conitinue discuss here] would be, after Yii3 is fully adopted and before Yii2 is fully unsupported, will there be enough maintainers to fix issues like PHP version compatibility or new language feature as they come and go? IMHO, having as many Yii3 library under the hood will easy this whole burden as Yii3 libraries will be upd-to-date with language feature set/compatibility |
From my understanding #19875 was not about using Yii3 packages through decorators, but using them directly, so people could switch to new API and easier migrate to Yii3. |
So basically, assuming that you understood it correctly, PR should be about new Cache API (Yii3 api Actually) for Yii2 with Yii3 cache package replacing Yii2 caching everywhere in the framework itself. Is that correct? |
I'm not entirely sure how to handle this, but I don't think that hiding Yii3 implementation behind decorators with Yii2 API is worth the effort - it is probably more work than maintenance of old implementation, and as a result you only get bugs and BC breaks. If Yii 2.2 is supposed to be a bridge between Yii 2.0 and Yii 3, then we should focus on that, not on refactoring. |
I agree that I got this wrong. I think that is clear now
How is the bridge supposed to look like? I think we have not done a good job defining this one. We need somehow to reach clear resolution on definition of the bridge. What entails the bridge a part from language bar and removing deprecations due to old stuffs? |