fix: #20002 optimize head request on serializeDataProvider #20007
Conversation
xicond
commented
Oct 14, 2023
xicond
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #20002 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #20007 +/- ##
==========================================
+ Coverage 48.95% 48.99% +0.03%
==========================================
Files 445 445
Lines 42844 42845 +1
==========================================
+ Hits 20973 20990 +17
+ Misses 21871 21855 -16
☔ View full report in Codecov by Sentry. |
…uest_in_serializer
|
Cheers, could you add the missing test? And a changelog line. |
…uest_in_serializer
…lizer' of https://github.com/xicond/yii2 into bugfix/20002-Superfluous_query_on_HEAD_request_in_serializer
…uest_in_serializer
|
I tried my best to add unit test which not covered before, seems codecov still not satisfy and not detect the coverage to test #20002, I'd need to include Mockery library $arrayDataProviderMocked->shouldReceive('getModels')->never() |
|
I'm not sure if adding it in the same test is not interfering with it. Try to exclude it to a new one. Also, Mockery is not needed, PHPUnit is enough. |
|
I separated the test, |
| @@ -400,6 +402,11 @@ public function dataProviderSerializeDataProvider() | |||
| ]; | |||
| } | |||
|
|
|||
| public function dataProviderHeadSerializeDataProvider() | |||
There was a problem hiding this comment.
This is unnecessary. Just use the same provider method in your test.
|
Cheers |
