Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaskedInputAsset::class. #20009

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix MaskedInputAsset::class. #20009

merged 1 commit into from
Oct 16, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4fe40f9) 48.95% compared to head (6ceb6f6) 48.95%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20009   +/-   ##
=======================================
  Coverage   48.95%   48.95%           
=======================================
  Files         445      445           
  Lines       42826    42826           
=======================================
  Hits        20964    20964           
  Misses      21862    21862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley added this to the 2.0.50 milestone Oct 16, 2023
@bizley bizley merged commit fe73d9c into yiisoft:master Oct 16, 2023
49 checks passed
@terabytesoftw terabytesoftw deleted the fix-maskedinputasset branch October 19, 2023 16:58
@olegbaturin
Copy link
Contributor

olegbaturin commented Nov 26, 2024

"bower-asset/punycode": "^2.2" is a commonJS lib and can't be used in the browser. The previous version 1.4, was a browser-compatible lib. The workaround is to use min.js from npm-asset.

module.exports = punycode;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaskedInput Widget javascript update request yii\widgets\MaskedInputAsset
3 participants