Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActiveDataProvider::prepareModels() to avoid SQL error with UNION queries #20246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Merge pull request #1 from cepaim/cepaim-prepareModels-union

a1807f9
Select commit
Loading
Failed to load commit list.
Open

Update ActiveDataProvider::prepareModels() to avoid SQL error with UNION queries #20246

Merge pull request #1 from cepaim/cepaim-prepareModels-union
a1807f9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 1s

64.93% (-0.01%) compared to 34d2396, passed because coverage increased by 0% when compared to adjusted base (64.94%)

View this Pull Request on Codecov

64.93% (-0.01%) compared to 34d2396, passed because coverage increased by 0% when compared to adjusted base (64.94%)

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (34d2396) to head (a1807f9).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
framework/data/ActiveDataProvider.php 50.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20246      +/-   ##
============================================
- Coverage     64.94%   64.93%   -0.01%     
- Complexity    11390    11394       +4     
============================================
  Files           430      430              
  Lines         36912    36919       +7     
============================================
+ Hits          23972    23975       +3     
- Misses        12940    12944       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.