Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize export-info scripts #23

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

Velsun3366
Copy link
Contributor

@Velsun3366 Velsun3366 commented Mar 7, 2024

Description

优化代码段,在条件判断里没有太多运算逻辑比对字符串,if分支又比较多的情况下用switch..case吧,运行会快一点

Linked Issues

resolve #24

Additional context

@Velsun3366 Velsun3366 mentioned this pull request Mar 7, 2024
@yjl9903 yjl9903 changed the title feat:optimize code chore: optimize export-info scripts Mar 7, 2024
@yjl9903
Copy link
Owner

yjl9903 commented Mar 7, 2024

呃,优化性能需要看 benchmarks 分析瓶颈的,这个脚本是爬数据用的,也就偶尔用用,所以其实无所谓

But, making it better is ok. Thanks!

@yjl9903 yjl9903 merged commit 13ffebc into yjl9903:main Mar 7, 2024
1 check passed
@Velsun3366
Copy link
Contributor Author

呃,优化性能需要看 benchmarks 分析瓶颈的,这个脚本是爬数据用的,也就偶尔用用,所以其实无所谓

But, making it better is ok. Thanks!

在你这能学好多专业黑话

@Velsun3366 Velsun3366 deleted the patch1 branch March 7, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[代码优化建议]
2 participants