Bump faraday dep version from >= 0.9.2 to >= 2 and migrate custom middleware. Fixes ylecuyer/survey-gizmo-ruby#121 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d migrate custom middleware
nicduke38degrees
changed the title
ylecuyer
reviewed
Aug 5, 2023
| @@ -18,8 +18,7 @@ Gem::Specification.new do |gem| | |||
| gem.add_dependency 'activesupport', '>= 3.0' | |||
| gem.add_dependency 'addressable', '>= 2' | |||
| gem.add_dependency 'awesome_print', '>= 1' | |||
| gem.add_dependency 'faraday', '>= 0.9.1' | |||
| gem.add_dependency 'faraday_middleware' | |||
| gem.add_dependency 'faraday', '>= 2.0' | |||
There was a problem hiding this comment.
could you remove ruby 2.4 and 2.5 from CI as faraday >2 requires at least tuby 2.6 and any way those version are already EOL
There was a problem hiding this comment.
Removed 2.4 and 2.5
Also updated gemspec to set min ruby version to >=2.6
Awaiting maintainer to run the Test workflow
All <3 Ruby is EOL, would you like further adjustments to remove all 2.x versions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the faraday ~2 update docs here
Also used referenced a some legacy and current faraday source code to guide me in the migration of the custom
ParseSurveyGizmomiddlewareThe new middleware template offered for faraday 2, contains some useful code comments
lostisland/faraday-middleware-template/blob/main/template/lib/gem_path/middleware.rb.erb
The legacy
ResponseMiddlewareclasslostisland/faraday_middleware/blob/main/lib/faraday_middleware/response_middleware.rb
The new implementation of JSON Response Middleware that is bundled with faraday 2
/lostisland/faraday/blob/main/lib/faraday/response/json.rb
Tests that cover the custom parser are passing. Wasn't sure if there was a need for adding more. I'm fairly new to Ruby to any pointer welcomed and I'm happy to add some specs given a bit of direction 🙏