Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start log line grouping earlier when possible #90

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Conversation

ymyzk
Copy link
Owner

@ymyzk ymyzk commented Sep 12, 2021

Description

tox-gh-actions writes ::group::tox: ... earlier if possible using other existing hooks provided by tox.
It shouldn't write the same ::group::tox: ... multiple times.

This PR mitigates the problem described in #39 and #80.

Expected Behavior

Before

py39-macos create: .tox/py39-macos
py39-macos installdeps: flake8
py39-macos inst: .tox/.tmp/package/1/UNKNOWN-0.0.0.zip
py39-macos installed: flake8==3.9.2,mccabe==0.6.1,pycodestyle==2.7.0,pyflakes==2.3.1,UNKNOWN @ .tox/.tmp/package/1/UNKNOWN-0.0.0.zip
::group::tox: py39-macos
py39-macos run-test-pre: PYTHONHASHSEED='1271455815'
py39-macos run-test: commands[0] | flake8
::endgroup::

After

py39-macos create: .tox/py39-macos
::group::tox: py39-macos
py39-macos installdeps: flake8
py39-macos inst: .tox/.tmp/package/1/UNKNOWN-0.0.0.zip
py39-macos installed: flake8==3.9.2,mccabe==0.6.1,pycodestyle==2.7.0,pyflakes==2.3.1,UNKNOWN @ .tox/.tmp/package/1/UNKNOWN-0.0.0.zip
py39-macos run-test-pre: PYTHONHASHSEED='1271455815'
py39-macos run-test: commands[0] | flake8
::endgroup::

@ymyzk ymyzk marked this pull request as draft September 12, 2021 08:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #90 (7665569) into master (d7a86ae) will increase coverage by 2.17%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   86.31%   88.49%   +2.17%     
==========================================
  Files           2        2              
  Lines          95      113      +18     
  Branches       25       28       +3     
==========================================
+ Hits           82      100      +18     
+ Misses          6        5       -1     
- Partials        7        8       +1     
Impacted Files Coverage Δ
src/tox_gh_actions/plugin.py 88.28% <91.30%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a86ae...7665569. Read the comment docs.

@ymyzk ymyzk changed the title Start log line grouping as soon as possible Start log line grouping earlier when possible Sep 12, 2021
@ymyzk ymyzk marked this pull request as ready for review September 12, 2021 08:23
@ymyzk ymyzk merged commit 59e01d6 into master Sep 12, 2021
@ymyzk ymyzk deleted the better-grouping-start branch September 12, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants