[WIP] コメントをつけられるようにする [closes #35] #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yucao24hours
force-pushed
the
comment
branch
2 times, most recently
from
0b5e9be to
05a9b7a
Compare
| @@ -2,6 +2,7 @@ class User < ActiveRecord::Base | |||
| include Authenticator | |||
|
|
|||
| has_many :posts, foreign_key: 'created_by_id' | |||
| has_many :comments, foreign_key: 'commented_by_id' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
yucao24hours
force-pushed
the
comment
branch
from
a0a0ad8 to
a7d83b3
Compare
Merged
| click_button 'create comment' | ||
|
|
||
| within '.comment__body' do | ||
| expect(page).must_have_content 'Lorem ipsum dolor sit amet' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
yucao24hours
force-pushed
the
comment
branch
2 times, most recently
from
e72987d to
efd2762
Compare
| resources :posts | ||
| resources :users, only: %i( index show ) | ||
| resources :posts do | ||
| resources :comments, only: %i( index new create ) |
There was a problem hiding this comment.
Do not use spaces inside percent literal delimiters.
yucao24hours
force-pushed
the
comment
branch
from
efd2762 to
4e175b0
Compare
yucao24hours
force-pushed
the
comment
branch
from
4e175b0 to
f81c38f
Compare
Merged
…anna create classes for comment author
yucao24hours
force-pushed
the
comment
branch
from
f81c38f to
09335e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77 が master マージされてからこのブランチをマージする必要があります。doneやってること
投稿に対してコメントをつけられるようにします。
TODO
対応 issue
connects to #35