Collection count performance #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramk
commented
Jan 2, 2017
aramk
commented
- Used collection hooks instead of observables to improve collection count performance. This was causing apps with millions of records to hang when viewing the dashboard. With hooks, the calculation isn't noticeable.
- Fixed onAfterAction().
- Updated dependencies.
- Allowed waitOn() to return cursors to subscribe to.
- Removed adminCollectionsCount which was causing very poor performance in an effort to debug the issue. - Passing widgets as empty array to dashboard will no longer render the defaults.
# Conflicts: # lib/both/router.coffee
Used collection hooks to update the collection count with better performance than observe().
# Conflicts: # lib/server/publish.coffee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.