Explicitly set url scheme when passing X-Forwarded-Proto #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let non-secure proxies tell a secure service to construct http URLs instead of https.
and default to http Slightly more secure?
|
As discussed on our call, we should be able to just toggle the https://github.com/django/django/blob/1.6.9/django/http/request.py#L119-L120 |
|
I think we should do both. |
I'm about to expand on what it means to set the scheme so I moved it to a function.
I'm about to expand on what happens in this function
|
updated |
|
👍 |
blaix
added a commit
that referenced
this pull request
Mar 6, 2015
Explicitly set url scheme when passing X-Forwarded-Proto
blaix
added a commit
that referenced
this pull request
Mar 6, 2015
This started as me adding docs for the changes in #7 but ended up as a rewrite. I think this reads better and also generalizes things as "fixing URLs" instead of just prefixing SCRIPT_NAME.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let non-secure proxies tell a secure service to construct http URLs instead of https.