fix: server doesn't dispatch message after sfn reconnected #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wujunzhuo is attempting to deploy a commit to the YoMo Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 59.30% 59.34% +0.04%
==========================================
Files 37 37
Lines 2730 2733 +3
==========================================
+ Hits 1619 1622 +3
- Misses 1010 1011 +1
+ Partials 101 100 -1 ☔ View full report in Codecov by Sentry. |
woorui
approved these changes
Jan 25, 2024
fanweixiao
approved these changes
Jan 25, 2024
fanweixiao
pushed a commit
that referenced
this pull request
Feb 26, 2024
# Description resolve #710 gracefully. ## Impact The server no longer uses the ID from the client as the storage key. Instead, it now uses an automatically incremented integer as the storage key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guarantee clientID will be changed after reconnect.