-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finalizer subcommand #172
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 46.33% 45.87% -0.46%
==========================================
Files 24 25 +1
Lines 2236 2413 +177
==========================================
+ Hits 1036 1107 +71
- Misses 1023 1122 +99
- Partials 177 184 +7 ☔ View full report in Codecov by Sentry. |
@Yuni-sa is this ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good.
Can we support this in multi and all and merge the namespaces?
Maybe we can do it that way and then put finalizers as include finalizers flag or something like that?
WDYT?
Not sure if there is a good implementation of this without #167 , after reasoning will be added I will create a new pr that will include it in all and multi. if we add this now it would probably all be deleted/changed in the next pr, I think the current implementation of using |
Ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
Iterates over all types of namespaced resources in the cluster (Including Custom Resources) check if they are in a terminating state by looking if they have a finalizer and a deletion timestamp, deletion of those resources is also supported by patching out the finalizer.
part of #117
this command is not added to the "all" command for future plans implementing a separate function for the supported resources after #167