Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CI step to package and publish Helm chart #306

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

Yuni-sa
Copy link
Contributor

@Yuni-sa Yuni-sa commented Jun 17, 2024

What this PR does / why we need it?

This PR adds a CI step in GitHub Actions to package and publish a Helm chart. It also includes ArtifactHub annotations in the Chart.yaml file to provide additional metadata for ArtifactHub listings.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs
  • This PR adds to a workflow

GitHub Issue

#285

Notes for your reviewers

  • The CI workflow relies on a branch gh-pages to be created first and in Settings/Pages the Source Branch should be gh-pages.
  • The gh-pages branch should be created before this PR is merged.
  • Created ArtifactHub annotations (artifacthub.io/license and artifacthub.io/links) in Chart.yaml.
  • To add the chart to ArtifactHub, we need to create an ArtifactHub repository and submit another PR to add an artifacthub-repo.yml file and a README.md to the gh-pages branch. (example: https://github.com/kubernetes-sigs/metrics-server/tree/gh-pages)

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.34%. Comparing base (ced2ef2) to head (d7040e6).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   41.34%   41.34%           
=======================================
  Files          61       61           
  Lines        3212     3212           
=======================================
  Hits         1328     1328           
  Misses       1671     1671           
  Partials      213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd linked an issue Jun 18, 2024 that may be closed by this pull request
@yonahd
Copy link
Owner

yonahd commented Jun 18, 2024

Created the branch.
@Yuni-sa can you rebase?

@Yuni-sa
Copy link
Contributor Author

Yuni-sa commented Jun 20, 2024

@yonahd

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yonahd yonahd merged commit 048a872 into yonahd:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: package and publish helm chart
3 participants