Skip to content
This repository has been archived by the owner on Jan 17, 2021. It is now read-only.

Add support for arrow keys and more #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

fjl5
Copy link

@fjl5 fjl5 commented Dec 11, 2017

This pull request slightly changes the UI behavior and the API, but I still wanted to share it:

  • Show suggestion as soon as any character is entered, not waiting for an "@" sign and the first character of the domain
  • Use up and down arrows (cursor keys) to browse through all matches
  • Don't autocomplete on focus leave, only on tab, right arrow, click
  • Only handle right arrow as autocomplete at end of input. This enables users to edit the text left of the "@" character without accidentally triggering autocomplete
  • Allow user to replace the list of domains, not just extend it (API change)
  • Make the separator character configurable; default is of course @

fjl5 added 2 commits December 11, 2017 11:09
- Show suggestion as soon as any character is entered
- Use up and down arrows to browse through all matches
- Don't autocomplete on focus leave, only on tab, right arrow, click
- Allow user to replace list of domains, not just extend it
@yongzhenlow
Copy link
Owner

@fjl5 Thanks for your input, I'll have a look :)

The goal of this change is to use the autocomplete feature for non-email
purposes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants