Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: click on placeholder adds focus to block #435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gloaysa
Copy link
Contributor

@gloaysa gloaysa commented Jan 8, 2025

Description

When clicking on the placeholder ("Type '/' for commands") the Block didn't gain focus. This is because the placeholder is a pseudo-element that was blocking the click event.

This change fixes it.

Fixes # (issue)

Type of change

Please tick the relevant option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Screenshots:

Before:

Screen.Recording.2025-01-08.at.10.07.18.mov

After:

Screen.Recording.2025-01-08.at.10.13.40.mov

Copy link

vercel bot commented Jan 8, 2025

@gloaysa is attempting to deploy a commit to the dargo's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant