Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterha_check_repl
has not workedwhen replication filters are given to only tailing servers,
like test cases added to tests/t/t_filter_incorrect.sh.
This is because perl evaluates the empty string as
false
andunless
block is executed despite another server has a configurationto declare that it never filters.
For example, there are three slaves and
only last server has a filtering setting for replicate_do_db,
masterha_check_repl
succeeds like the followings.