Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update launcher icons #202

Merged
merged 1 commit into from
Nov 8, 2023
Merged

style: update launcher icons #202

merged 1 commit into from
Nov 8, 2023

Conversation

M00NJ
Copy link
Member

@M00NJ M00NJ commented Nov 8, 2023

@SuhasDissa I took a close look at the PR you made after I added the new icon for VibeYou. I made sure to make all the same changes here as well, so I think we are good to go this time :)

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(too lazy to test but looks good to me)

@M00NJ
Copy link
Member Author

M00NJ commented Nov 8, 2023

(too lazy to test but looks good to me)

I tested it :)

@M00NJ M00NJ merged commit 7cde91a into you-apps:main Nov 8, 2023
1 check passed
@SuhasDissa
Copy link
Member

@M00NJ The round icon is not needed if it looks visually similar to the normal icon. That's why I removed it in VibeYou

More info here

@M00NJ
Copy link
Member Author

M00NJ commented Nov 8, 2023

@M00NJ The round icon is not needed if it looks visually similar to the normal icon. That's why I removed it in VibeYou

Yes, that's why I removed all the round icons and also removed it from the manifest. Did I miss one?

@M00NJ M00NJ deleted the update-icon branch November 19, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants