Cherry pick PR #1969: Add GetPersistentSetting() to h5vcc_settings. (#…

…1994) Refer to the original PR: #1969 Add a persistent settings getter to validate set persistent h5vcc settings. The getter is a string getter that maps to the various types that allows for empty string returns when the getter fails. b/305057554 Co-authored-by: Brian Ting <[email protected]>
youtube · Jan 2, 2024 · 2b232a8 · 2b232a8
1 parent 5c80762
commit 2b232a8
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/cobalt/h5vcc/h5vcc_settings.cc b/cobalt/h5vcc/h5vcc_settings.cc
@@ -104,5 +104,22 @@ bool H5vccSettings::Set(const std::string& name, SetValueType value) const {
   return false;
 }
 
+void H5vccSettings::SetPersistentSettingAsInt(const std::string& key,
+                                              int value) const {
+  if (persistent_settings_) {
+    persistent_settings_->SetPersistentSetting(
+        key, std::make_unique<base::Value>(value));
+  }
+}
+
+int H5vccSettings::GetPersistentSettingAsInt(const std::string& key,
+                                             int default_setting) const {
+  if (persistent_settings_) {
+    return persistent_settings_->GetPersistentSettingAsInt(key,
+                                                           default_setting);
+  }
+  return default_setting;
+}
+
 }  // namespace h5vcc
 }  // namespace cobalt
diff --git a/cobalt/h5vcc/h5vcc_settings.h b/cobalt/h5vcc/h5vcc_settings.h
@@ -58,6 +58,11 @@ class H5vccSettings : public script::Wrappable {
   // invalid or not set to the expected value.
   bool Set(const std::string& name, SetValueType value) const;
 
+  void SetPersistentSettingAsInt(const std::string& key, int value) const;
+
+  int GetPersistentSettingAsInt(const std::string& key,
+                                int default_setting) const;
+
   DEFINE_WRAPPABLE_TYPE(H5vccSettings);
 
  private:

diff --git a/cobalt/h5vcc/h5vcc_settings.idl b/cobalt/h5vcc/h5vcc_settings.idl
@@ -14,4 +14,6 @@
 
 interface H5vccSettings {
   boolean set(DOMString name, (long or DOMString) value);
+  void setPersistentSettingAsInt(DOMString name, long value);
+  long getPersistentSettingAsInt(DOMString name, long default_setting);
 };