Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure QuicChromiumPacketWriter isn't still tracked when deleted.
Attempt to address increased crashes in the QuicChromiumPacketWriter destructor. The QuicChromiumPacketWriter destructor crashes seem to indicate that there is a double free. The destructor is called from both the QuicConnection destructor and during QuicConnection::MigratePath. A double free appears to only be possible after MigratePath is called with the same writer as currently used, but on a connection that is not connected. The increase possibly means a race between a connection teardown and migration was made more likely to occur as a result of recent performance improvements. This adds a check and pointer reset that should avoid having a stale QuicChromiumPacketWriter pointer in the QuicConnection. b/388316262
- Loading branch information