Skip to content

Commit

Permalink
Cherry pick PR #2043: Make run_all_unittests a source_set (#2073)
Browse files Browse the repository at this point in the history
Refer to the original PR: #2043

Fix ps5 modular tests which depend on base/test:run_all_unittests

On PS5, the static library hidden symbols are not visible to the linked
shared library.
The object file hidden symbols are visible to the linked shared library

Refer to error details in  b/246412559#comment71

b/246412559

Co-authored-by: Niranjan Yardi <[email protected]>
  • Loading branch information
1 parent 9c633f1 commit 7fe808c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion base/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,9 @@ if (!is_starboard) {
}
}

static_library("run_all_unittests") {
# TODO: b/315170518 - Revert to static library after fixing
# symbol visibility issues for windows based modular platform builds.
source_set("run_all_unittests") {
testonly = true
sources = [
"run_all_unittests.cc",
Expand Down

0 comments on commit 7fe808c

Please sign in to comment.