Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_starboard a global variable #4791

Merged

Conversation

niranjanyardi
Copy link
Contributor

@niranjanyardi niranjanyardi commented Jan 29, 2025

b/393160172

Set is_starboard = false globally and true for linux based cobalt and starboard toolchains.
Remove current toolchain info from is_cobalt_hermetic_build which makes it easier to be replaced by is_starboard

@niranjanyardi niranjanyardi requested a review from a team as a code owner January 29, 2025 23:35
base/BUILD.gn Outdated Show resolved Hide resolved
@niranjanyardi
Copy link
Contributor Author

niranjanyardi commented Jan 29, 2025

@andrewsavage1

  1. i tried out putting in common.gn - didnt work.

  2. I tried is_starboard false globally and is_starboard = true in the linux cobalt and starboard toolchain args - but that doesn't work

3)making is_starboard = true in the linux args.gn and then override it in the linux host toolchain works . there's a risk of random other toolchains having is_starboard = true (like roboelectric) but maybe im being too paranoid at this point.

See b/393160172 for details

build/toolchain/linux/BUILD.gn Outdated Show resolved Hide resolved
cobalt/build/configs/linux-x64x11/args.gn Outdated Show resolved Hide resolved
@andrewsavage1
Copy link
Contributor

there's a risk of random other toolchains having is_starboard = true (like roboelectric) but maybe im being too paranoid at this point.

We can just look at the value of is_starboard for all the toolchains on linux-x64x11 and linux-evergreen platform (by printing it out), that'll be enough to verify

@niranjanyardi niranjanyardi enabled auto-merge (squash) January 31, 2025 00:46
@niranjanyardi niranjanyardi force-pushed the set_is_starboard_toolchain_args branch from d803ff3 to e010714 Compare February 5, 2025 01:01
@niranjanyardi niranjanyardi marked this pull request as draft February 5, 2025 01:01
auto-merge was automatically disabled February 5, 2025 01:01

Pull request was converted to draft

@niranjanyardi niranjanyardi requested a review from y4vor February 5, 2025 02:00
@niranjanyardi niranjanyardi marked this pull request as ready for review February 5, 2025 02:05
@niranjanyardi niranjanyardi force-pushed the set_is_starboard_toolchain_args branch from c82b91e to e1b763d Compare February 5, 2025 02:06
@niranjanyardi niranjanyardi force-pushed the set_is_starboard_toolchain_args branch from e1b763d to b6b1ae0 Compare February 5, 2025 02:49
@niranjanyardi niranjanyardi requested a review from a team as a code owner February 5, 2025 02:49
@niranjanyardi niranjanyardi changed the title Set is_starboard false globally and to true in the toolchain args Make is_starboard a global variable Feb 5, 2025
@niranjanyardi niranjanyardi force-pushed the set_is_starboard_toolchain_args branch from b6b1ae0 to 74318f0 Compare February 5, 2025 20:55
@niranjanyardi niranjanyardi enabled auto-merge (squash) February 5, 2025 21:39
build/config/BUILDCONFIG.gn Show resolved Hide resolved
@niranjanyardi niranjanyardi merged commit e601b67 into youtube:main Feb 5, 2025
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants