-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make is_starboard a global variable #4791
Make is_starboard a global variable #4791
Conversation
3)making is_starboard = true in the linux args.gn and then override it in the linux host toolchain works . there's a risk of random other toolchains having is_starboard = true (like roboelectric) but maybe im being too paranoid at this point. See b/393160172 for details |
We can just look at the value of is_starboard for all the toolchains on linux-x64x11 and linux-evergreen platform (by printing it out), that'll be enough to verify |
d803ff3
to
e010714
Compare
Pull request was converted to draft
c82b91e
to
e1b763d
Compare
e1b763d
to
b6b1ae0
Compare
b6b1ae0
to
74318f0
Compare
b/393160172
Set is_starboard = false globally and true for linux based cobalt and starboard toolchains.
Remove current toolchain info from is_cobalt_hermetic_build which makes it easier to be replaced by is_starboard