Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kokoro mac #4806

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Remove Kokoro mac #4806

merged 1 commit into from
Feb 3, 2025

Conversation

briantting
Copy link
Contributor

b/390205588

@briantting
Remove Kokoro mac
56b9c70 
b/390205588
@briantting briantting marked this pull request as ready for review January 31, 2025 02:27
isarkis
isarkis reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@isarkis isarkis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not planning to support Mac in the future?

@oxve
Copy link
Contributor

oxve commented Feb 3, 2025 •
edited
Loading

Are we not planning to support Mac in the future?

We can revert this change when and if. No use keeping the dead code around until we know.

@briantting briantting merged commit c513a47 into youtube:main Feb 3, 2025
88 of 89 checks passed
@briantting briantting deleted the mac branch February 3, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isarkis isarkis isarkis left review comments

@oxve oxve oxve approved these changes

@kaidokert kaidokert Awaiting requested review from kaidokert

@haozheng-cobalt haozheng-cobalt Awaiting requested review from haozheng-cobalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briantting @oxve @isarkis