Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ysig,
I can't be certain that this github action will work out of the box and I will likely need to do some live debugging with respect to actions deploying to gh-pages. I can test this by deploying this actual branch
doc-ci
to gh-pages and seeing if it all worksSome points not tackled by this PR:
gh-pages
branch seems to have several version there although on the live published docs, there's no way to choose between them. You can however manually enter it in the url.There is an
index.html
in thegh-pages
branch which points to a specific version, i.e."0.1a8"
, however I do not know how to update this automatically (either by the gh-actions or even how to identify which version is latest)latest
and the
index.html
to be updated to reflect this, i.e.You can see this in the workflow file
Other points
doc
which is installable withpip install -e ".[doc]"
MutableSet
fromcollections
MultiscaleLaplacianFast
from the docs as I found a changelog entry saying it was removed and replaced withMultiscaleLaplacian
.pynauty
. I could not find a documentation page for it so I do not know how to update this link or whether such a link exists. Normally I would play around with links at published docs but it seempynauty
does not have live docs.KKMMN2016
doctest
seems to be running any doctests present in imported scipy modules, some of which are failing (despite them seeming correct). All of GraKels doctests seem fine. This doesn't stop GraKel's documentation from building itself but it does produce errors which CI system will pick up on and likely fail (since they think the whole doc bulding failed)1. One option is just don't
doctest
for the doc release (implemented)2. Do the
doctest
but ignore errors.2. Lastly, fix it. However I couldn't figure it out https://www.sphinx-doc.org/en/master/usage/extensions/doctest.html
Written inside
.github/workflows/doc.yaml