Split into sans-IO crate (librice_proto) and crate with IO (librice) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be Md5() and use the realm not the nonce.
1. librice-proto handles the state machine and contains no async code at all and can in theory be driven from a sync context 2. librice is the async-std implementation based on librice-proto
derivative can be reimplements relatively easily. once_cell now has an equivalent in the standard library.
And remove some unused dependencies
Can succesfully do a WebRTC call on localhost.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 73.75% 78.13% +4.38%
==========================================
Files 17 25 +8
Lines 3242 4180 +938
==========================================
+ Hits 2391 3266 +875
- Misses 851 914 +63 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Also adds the beginning of a C-compatibility interface for (librice_proto).