Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external stun-proto crate. #39

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Use external stun-proto crate. #39

merged 2 commits into from
Jun 19, 2024

Conversation

ystreet
Copy link
Owner

@ystreet ystreet commented Jun 19, 2024

Removes 3+MB of code from the resulting binary.

Still currently used for development for logging but dependants can
make their own coice as to if they want to use env-filter or some other
log selection crate.
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (0546364) to head (ec660ef).

Current head ec660ef differs from pull request most recent head 5b54863

Please upload reports for the commit 5b54863 to get more accurate results.

Files Patch % Lines
librice/src/agent.rs 42.85% 4 Missing ⚠️
librice-proto/src/conncheck.rs 76.92% 3 Missing ⚠️
librice/src/stream.rs 66.66% 2 Missing ⚠️
librice/src/stun.rs 0.00% 2 Missing ⚠️
librice-proto/src/agent.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   78.23%   84.26%   +6.03%     
==========================================
  Files          25       18       -7     
  Lines        4167     2714    -1453     
==========================================
- Hits         3260     2287     -973     
+ Misses        907      427     -480     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Now depends on stun-types/stun-proto for STUN.
@ystreet ystreet enabled auto-merge (rebase) June 19, 2024 04:16
@ystreet ystreet merged commit 557a6c9 into main Jun 19, 2024
5 checks passed
@ystreet ystreet deleted the stun-types branch June 19, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant