[DoodStream] Add extractor #32979
Open
[DoodStream] Add extractor #32979
+90
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
mp3butcher
force-pushed
the
d00dstream
branch
3 times, most recently
from
de01b5d
to
6456200
Compare
mp3butcher
changed the title
mp3butcher
force-pushed
the
d00dstream
branch
3 times, most recently
from
31d3220
to
dde081c
Compare
mp3butcher
force-pushed
the
d00dstream
branch
from
dde081c
to
c09207a
Compare
dirkf
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Thanks for the update and decoding the pass_md5/token stuff.
I've made some comments for information, but I'll apply the changes to the old PR with attribution. The question to be settled is whether the '/d/' page ever embeds a link other than the matching '/e/' page.
youtube_dl/extractor/doodstream.py
Outdated
| auth_url = ('https://%s/' % host) + self._html_search_regex( | ||
| r'(/pass_md5.*?)\'', webpage, 'pass_md5') | ||
| headers = { | ||
| 'User-Agent': 'Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/66.0', |
There was a problem hiding this comment.
This doesn't seem to be necessary:
Suggested change
| 'User-Agent': 'Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/66.0', |
youtube_dl/extractor/doodstream.py
Outdated
Comment on lines
80
to
81
| final_url = authpage + ''.join([random.choice(string.ascii_letters + string.digits) for _ in | ||
| range(10)]) + "?token=" + token + "&expiry=" + str(int(time.time() * 1000)) |
There was a problem hiding this comment.
Prefer (with whatever indentation flake8 allows):
Suggested change
| final_url = authpage + ''.join([random.choice(string.ascii_letters + string.digits) for _ in | |
| range(10)]) + "?token=" + token + "&expiry=" + str(int(time.time() * 1000)) | |
| final_url = update_url_query( | |
| authpage + ''.join((random.choice(string.ascii_letters + string.digits) | |
| for _ in range(10))), { | |
| 'token': token, | |
| 'expiry': int(time.time() * 1000), | |
| }) |
But in the original, s/str/compat_str/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update of outdated extractors:
Closes #28903.
Closes #28008.
Closes #31003