Skip to content

Commit

Permalink
fix(Accounts,Bundles): better defaults for accounting settings [YTFRO…
Browse files Browse the repository at this point in the history
…NT-3891]
  • Loading branch information
ma-efremoff committed Nov 16, 2023
1 parent 8012884 commit 8a79e4b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ Available flags (**default values** are highlighted in bold):
| Flag name | Allowed values | Description |
| :----------------------------------- | :---------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| web_json_value_format | **"schemaless"**, "yql" | Allows to use `YQLv3 types` [YTFRONT-2804](https://nda.ya.ru/t/bgh9NWJ16fPRp4) |
| enable_per_bundle_tablet_accounting | **false**, true | Allows editing of resources of tablets through BundleEditorDialog [YTFRONT-2851](https://nda.ya.ru/t/xnLq-3Dm6fPYPo) |
| enable_per_account_tablet_accounting | **true**, false | Allows editing of resources of tablets through AccountEditorDialog [YTFRONT-2851](https://nda.ya.ru/t/xnLq-3Dm6fPYPo) |
| enable_per_bundle_tablet_accounting | **true**, false | Allows editing of resources of tablets through BundleEditorDialog [YTFRONT-2851](https://nda.ya.ru/t/xnLq-3Dm6fPYPo) |
| enable_per_account_tablet_accounting | **false**, true | Allows editing of resources of tablets through AccountEditorDialog [YTFRONT-2851](https://nda.ya.ru/t/xnLq-3Dm6fPYPo) |
| per_bundle_accounting_help_link | **null**, url as string | Help link for resources of tablets to display from AccountEditorDialog about moving the resources to bundles [YTFRONT-2851](https://nda.ya.ru/t/xnLq-3Dm6fPYPo) |
| enable_maintenance_api_nodes | **null**, boolean | Allows to use `add_maintenance`/`remove_maintenance` commands from `Comopnents/Nodes` page [YTFRONT-3792](https://nda.ya.ru/t/RvueJLzN6fWx3h) |
| enable_maintenance_api_proxies | **null**, boolean | Allows to use `add_maintenance`/`remove_maintenance` commands from `Components/HTTP Proxies` and `Components/RPC Proxies` pages [YTFRONT-3792](https://nda.ya.ru/t/RvueJLzN6fWx3h) |
Expand Down
5 changes: 2 additions & 3 deletions packages/ui/src/ui/store/selectors/global/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@ export const isYqlTypesSupported = createSelector(
export const getClusterUiConfig = (state: RootState) => state.global.clusterUiConfig;

export const getClusterUiConfigEnablePerAccountTabletAccounting = (state: RootState) => {
const {enable_per_account_tablet_accounting: value} = state.global.clusterUiConfig;
return value === undefined ? true : value;
return state.global.clusterUiConfig.enable_per_account_tablet_accounting ?? false;
};
export const getClusterUiConfigEnablePerBundleTabletAccounting = (state: RootState) =>
state.global.clusterUiConfig.enable_per_bundle_tablet_accounting;
state.global.clusterUiConfig.enable_per_bundle_tablet_accounting ?? true;
export const getClusterUiConfigBundleAccountingHelpLink = (state: RootState) =>
state.global.clusterUiConfig.per_bundle_accounting_help_link;

Expand Down

0 comments on commit 8a79e4b

Please sign in to comment.