Simple solution to issue #3413 Removing inserted blank lines from pagnated output #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_paginated_output We make the lazy assumtion that when you can't turn off pagenation with something like "terminal length 0", that Dell always puts an undesirable blank line before the --More-- prompt. :-) This will make diffs fail between TFTPd and oxidized copies of the same config.
powerconnect: Remove undesirable inserted blank lines during pagination. Fixes ytti#3413
| @@ -5,7 +5,7 @@ class PowerConnect < Oxidized::Model | |||
|
|
|||
| comment '! ' | |||
|
|
|||
| expect /^\s*--More--\s+.*$/ do |data, re| | |||
| expect /\n\s*--More--\s+.*/ do |data, re| # Also grab the blank line above the --More-- | |||
There was a problem hiding this comment.
Why remove the End of Line ($) at the end of the match?
There was a problem hiding this comment.
Howdy,
good question. :-) Though I'm not an expert but it seems redundant, because without a /m modifier, the '.' does not match '\n' and '.*' is greedy so it will grab all up to the next '\n' anyway, so it's the same? We could put it back in if you like. :-)
Clif
clifcox
deleted the
3413-Removing_inserted_blank_lines_from_paginated_output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the lazy assumption that when you can't turn off pagination with something like "terminal length 0", that Dell always puts an undesirable blank line before the --More-- prompt. :-)
This will make diffs fail between TFTPd and oxidized copies of the same config.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Perhaps Closes #3413 ?