Skip to content

Commit

Permalink
Fix flyte-core rendering when flyteagent enabled (flyteorg#4922)
Browse files Browse the repository at this point in the history
- Flyte agent now tries to render a specific set of podLabels, so
   assumes that there is an empty `podLabels: {}` set. This change to
   values.yaml for flyte-core ensures empty values are there.

 - Fixes:

   Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels

Signed-off-by: ddl-ebrown <[email protected]>
  • Loading branch information
ddl-ebrown authored and yubofredwang committed Mar 26, 2024
1 parent 6754b2f commit 15e3696
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/flyte-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ helm install gateway bitnami/contour -n flyte
| flyteagent.enabled | bool | `false` | |
| flyteagent.plugin_config.plugins.agentService.defaultAgent.endpoint | string | `"dns:///flyteagent.flyte.svc.cluster.local:8000"` | |
| flyteagent.plugin_config.plugins.agentService.defaultAgent.insecure | bool | `true` | |
| flyteagent.podLabels | object | `{}` | Labels for flyteagent pods |
| flyteconsole.affinity | object | `{}` | affinity for Flyteconsole deployment |
| flyteconsole.enabled | bool | `true` | |
| flyteconsole.ga.enabled | bool | `false` | |
Expand Down
2 changes: 2 additions & 0 deletions charts/flyte-core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,8 @@ flyteagent:
defaultAgent:
endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
insecure: true
# -- Labels for flyteagent pods
podLabels: {}

#
# FLYTEPROPELLER SETTINGS
Expand Down

0 comments on commit 15e3696

Please sign in to comment.