This repository has been archived by the owner on May 25, 2018. It is now read-only.
Popover fixes #414
Open
Popover fixes #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work, only issue was the outer div that caused issues with other components, change the div to a span and works perfect |
|
with new issues,
this issue is triggered when i use palcement='right', but when use placement='top', it is ok. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day!
I was trying to use this package in my project for some quick feature I needed to implement and came across a bug so I decided to fix it myself as I'm pretty limited in time.
The first bug was that v-if="show" was not removing the component from the dom. Wrapping the v-if logic in an outer div fixed that.
The second bug started happening after the first fix: upon triggering the popover, there would be some small amount of time where the popover appeared at the original location. To fix that I replaced the setTimeout call with Vue's own nextTick. That seemed to do the trick.
Please feel free to test this more extensively and merge or not. As I've said, I needed this for my personal use, and thought I might as well submit a PR in case you come across similar issues. I'm linking my project's vue-strap dependency to my own branch in the meantime.
Thank you!