Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, since the plugins repo will require plugins to have tests in the future, here is a very basic test.
setup.sh
will build the binary during CI.tests/test_cln_ntfy.py
contains the test and currently only checks if the plugins starts with the node and if the plugin options exist.It would be nice to actually test a notification!
You can run tests like this:
Install dependencies:
Build the plugin
run tests :