Skip to content

Commit

Permalink
Bugfix: use correct listenerID when UpdateLoadBalancer (#117)
Browse files Browse the repository at this point in the history
Signed-off-by: zhangziren [email protected]

Co-authored-by: zhangziren <[email protected]>
  • Loading branch information
zhangziren1988 and zhangziren authored Aug 23, 2021
1 parent 008ce2c commit 4d5409f
Showing 1 changed file with 11 additions and 16 deletions.
27 changes: 11 additions & 16 deletions pkg/qingcloud/qingcloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -339,25 +339,20 @@ func (qc *QingCloud) UpdateLoadBalancer(ctx context.Context, _ string, service *
return err
}

var (
toDeleteBackends []*string
toAddBackends []*apis.LoadBalancerBackend
)
for _, listener := range listeners {
toDelete, toAdd := diffBackend(listener, nodes)
toDeleteBackends = append(toDeleteBackends, toDelete...)
toAddBackends = append(toAddBackends, generateLoadBalancerBackends(toAdd, listener, service.Spec.Ports)...)
}
if len(toDeleteBackends) > 0 {
err = qc.Client.DeleteBackends(toDeleteBackends)
if err != nil {
return err
if len(toDelete) > 0 {
err = qc.Client.DeleteBackends(toDelete)
if err != nil {
return err
}
}
}
if len(toAddBackends) > 0 {
_, err = qc.Client.CreateBackends(toAddBackends)
if err != nil {
return err
toAddBackends := generateLoadBalancerBackends(toAdd, listener, service.Spec.Ports)
if len(toAddBackends) > 0 {
_, err = qc.Client.CreateBackends(toAddBackends)
if err != nil {
return err
}
}
}

Expand Down

0 comments on commit 4d5409f

Please sign in to comment.