Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalance: set nodecount to 2 when create lb #103

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

duanjiong
Copy link
Collaborator

Notice: We don't change the number of nodes of an existing load balancer, you can change it in the portal if you want.

and fixed some formatting issues

Signed-off-by: Duan Jiong [email protected]

Notice: We don't change the number of nodes of an existing load balancer, you can change it in the interface if you want.

and fixed some formatting issues

Signed-off-by: Duan Jiong <[email protected]>
@ks-ci-bot ks-ci-bot added dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2020
@duanjiong
Copy link
Collaborator Author

/assign @zheng1

@duanjiong
Copy link
Collaborator Author

#101

@zheng1
Copy link
Member

zheng1 commented Jul 21, 2020

It is more convenient to support the definition of count in the annotation, and we also need to support the modification operation. But now this modification is a big improvement

@zheng1
Copy link
Member

zheng1 commented Jul 21, 2020

/approve
/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanjiong, zheng1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@ks-ci-bot ks-ci-bot merged commit 7278181 into yunify:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants