Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add get method for streamer #61

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

koriansidibe
Copy link

To retrieve RTMP stats, access to the streamer object is required.

Copy link
Owner

@yutopp yutopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your PR!

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2ae4e86) 62.61% compared to head (6367d2f) 62.57%.

Files Patch % Lines
conn.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   62.61%   62.57%   -0.04%     
==========================================
  Files          36       36              
  Lines        1899     1900       +1     
==========================================
  Hits         1189     1189              
- Misses        569      570       +1     
  Partials      141      141              
Flag Coverage Δ
unittests 62.57% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yutopp yutopp merged commit d42d059 into yutopp:master Dec 12, 2023
2 of 4 checks passed
@koriansidibe
Copy link
Author

LGTM. Thank you for your PR!

Thank you for approving my PR! Are there any plans to create a new tag in the coming days?

@yutopp
Copy link
Owner

yutopp commented Jan 2, 2024

Oops, I'm sorry. Thank you for bringing it to my attention. I've just released the v0.0.6 tag now. If you have any further questions or concerns, please feel free to reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants