Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #48 #49

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Conversation

tensorturtle
Copy link
Contributor

@tensorturtle tensorturtle commented Jan 9, 2025

Fixes #48

Changes:

  • Restore backward compatible expected behavior for get_fitness_machine_feature method, which in v0.4.0 was changed to return a tuple, where it was previously not a tuple. Add two convenience methods to this end.
  • Improve singular/plural naming internally.
  • Fix type annotations

… method and improve singular/plural naming consistency. Fix type annotations.
@tensorturtle
Copy link
Contributor Author

tensorturtle commented Jan 9, 2025

@zacharyedwardbull Can you take a look at this? The Github actions CI fails for Python 3.7 only. Did it get deprecated at some point in the recent past?

Edit: Looking at the github actions logs, it seems that the Ubuntu version was automatically upgraded (now running 24.04), for which a python 3.7 build does not exist. I manually checked the link provided in the error https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json and for python 3.7, only up to ubuntu 22.04 is supported.

How would you like to proceed? I think both paths are reasonable:

  • Edit github actions to run on ubuntu 22.04
  • Deprecate python 3.7 support for this lib.

@zacharyedwardbull
Copy link
Owner

zacharyedwardbull commented Jan 11, 2025

Hi @tensorturtle thanks for creating this fix. I've updated the python test versions in 3132d08 to remove 3.7 and add the newer versions. Please rebase and then the tests should pass.

@tensorturtle
Copy link
Contributor Author

@zacharyedwardbull Thank you. It's ready.

@zacharyedwardbull zacharyedwardbull merged commit 68d22c4 into zacharyedwardbull:master Jan 25, 2025
6 checks passed
@zacharyedwardbull
Copy link
Owner

Merged, thanks @tensorturtle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking changes in v0.4.0
2 participants