Feature/37677/zak39 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up_list (issue 37677) Signed-off-by: Sebastien Marinier <[email protected]>
Signed-off-by: Sebastien Marinier <[email protected]>
…ring-with-users Signed-off-by: Baptiste Fotia <[email protected]>
I added the $shareWithGroupOnlyExcludeGroupsList variable as a property in the Collaborators classes and fix the CI (Psalm). Signed-off-by: Baptiste Fotia <[email protected]>
I ran composer cs:fix for files from Collaborators folder and the ContactsStore.php file. Signed-off-by: Baptiste Fotia <[email protected]>
I deleted end of line for en_GB.json and fr.json files. Signed-off-by: Baptiste Fotia <[email protected]>
Modify settings label (shareapi_only_share_with_group_members_exclude_group_list) accordingly to last discussions Signed-off-by: Sebastien Marinier <[email protected]>
Conflict with 06d8a03 Signed-off-by: Sebastien Marinier <[email protected]>
Add shareWithGroupMembersExcludeGroupsList in default settings Signed-off-by: Sebastien Marinier <[email protected]>
…up_list Prevent json_decode(null) from config mock (getAppValue) Signed-off-by: Sebastien Marinier <[email protected]>
Fixed lint errors (php-cs-fixer) Signed-off-by: Sebastien Marinier <[email protected]>
Reduce redundant code lines, harmonize function name, use wording chosen with dicsussion Signed-off-by: Sebastien Marinier <[email protected]> no i18n files in PR Signed-off-by: Sebastien Marinier <[email protected]> refactor(l10n): no line break in the end file I removed the line breaks in the end file of en_GB.json and fr.json files. Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
I initialized the `$shareWithGroupOnlyExcludeGroupsList` var in the constructor with an empty array. Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
…ring-with-users Signed-off-by: Sébastien Marinier <[email protected]>
Signed-off-by: Sebastien Marinier <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist