Skip to content

Commit

Permalink
Re-enable tests for GraalVM >= 24.2
Browse files Browse the repository at this point in the history
  • Loading branch information
zakkak committed Oct 4, 2024
1 parent 335e4fb commit 9bc84d1
Showing 1 changed file with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ public void testCorrectLocales(String country, String language, String translati
.log().all();
}

// Disable test with GraalVM 24.2 for JDK 24 and later till we reach a conclusion in
// https://github.com/quarkusio/quarkus/discussions/43533
@DisableIfBuiltWithGraalVMNewerThan(value = GraalVMVersion.GRAALVM_24_1_0)
@ParameterizedTest
@CsvSource(value = {
"en-US|en|US Dollar",
Expand All @@ -66,9 +63,6 @@ public void testCurrencies(String country, String language, String currency) {
.log().all();
}

// Disable test with GraalVM 24.2 for JDK 24 and later till we reach a conclusion in
// https://github.com/quarkusio/quarkus/discussions/43533
@DisableIfBuiltWithGraalVMNewerThan(value = GraalVMVersion.GRAALVM_24_1_0)
@ParameterizedTest
@CsvSource(value = {
"Asia/Tokyo|fr|heure normale du Japon",
Expand All @@ -90,13 +84,14 @@ public void testTimeZones(String zone, String language, String name) {
}

@Test
@DisableIfBuiltWithGraalVMNewerThan(value = GraalVMVersion.GRAALVM_24_1_0)
@DisableIfBuiltWithGraalVMNewerThan(value = GraalVMVersion.GRAALVM_24_1_999)
public void testDefaultLocaleBefore24_2() {
RestAssured.given().when()
.get("/default/de-CH")
.then()
.statusCode(HttpStatus.SC_OK)
/*
* Prior to GraalVM 24.2, the locale could not be changes at runtime.
* "Švýcarsko" is the correct name for Switzerland in Czech language.
* Czech is the default language as per quarkus.native.user-language=cs.
*/
Expand All @@ -112,6 +107,7 @@ public void testDefaultLocaleAfter24_1() {
.then()
.statusCode(HttpStatus.SC_OK)
/*
* Starting with GraalVM 24.2, the locale can be set at runtime.
* "Schweiz" is the correct name for Switzerland in German.
* German is the default language as per the `quarkus.test.arg-line` in application.properties.
*/
Expand Down

0 comments on commit 9bc84d1

Please sign in to comment.